👋 Welcome back sacharya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@shruacha1234 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Webrevs

• 01: Full - Incremental (57e506ff)
• 00: Full (d53a3cd5)

/approval JDK-8351458 request Clean backport, Refactored to move "prepare for close" logic into UnixDispatcher to simplify code and handle blocked threads during socket close more effectively in 21u-dev.

@shruacha1234
JDK-8351458: The approval request has been created successfully.

⚠️ @shruacha1234 the commit cabd1fa3863b1fced596889fd15e197d2ee96b19 does not refer to an issue in project JDK.

This backport pull request has now been updated with issue from the original commit.

@shruacha1234 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@shruacha1234 Please read https://openjdk.org/projects/jdk-updates/approval.html

In particular in Rule 1 it says:

[...] In that comment the requester must describe why it's important
to fix this bug, explain the nature of the fix, estimate its risk and describe
its test coverage. [...]

Nothing like that is in the existing fix request comment.

⚠️ @shruacha1234 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jerboaa
I ran jdk_nio and jdk_net jtreg tests and there is no regression seen

I’m backporting 8351458 because it refactors to move "prepare for close" logic into UnixDispatcher to simplify code and handle blocked threads during socket close more effectively which is a necessary foundation for other functional fix, which needs to be backported to JDK21 openjdk/jdk#25817. This fix is built on top of this refactoring. Without backporting 8351458, openjdk/jdk#25817 cannot be cleanly ported to JDK21